I'm debating my faith because of the existence of hell if God was all seeing all powerful and all knowing why would he allow some people to never become Christians
God wants us to love Him. But we can't be
forced into loving Him. By definition, love is only ever freely given; it can't be compelled. And so, we live in a world where God has made it possible for the creatures He's made (the one's created in His image), to freely choose to know and love Him. But in making this possible, it is necessary that we be able
not to choose God, and even to hate Him. Without a real, concrete choice between loving God and not loving Him, we aren't truly free in our choice and without such freedom of choice love isn't possible. And so, there are people who love God and people who don't.
God is good. He is also all-knowing. And so, of all the possible worlds God could have made, He made the world that, in His omniscience, He knew the greatest number of people would freely choose to love Him: our world. We can deduce from the nature of our world that it isn't possible for God to have created another world in which more people with free agency choose to love Him. If such a world were possible, God, being good, would have created that world. But He didn't; He has created our world. And so, we live in the one world out of all possible worlds God could have made in which the most people are saved. Our world, then, isn't a testament to God's cruelty, but, rather, to His goodness.
by that logic he knew they would go to hell but made them anyway
Yes. We do the same thing without a moment's thought in a variety of ways. For example, every time we get into a car and drive on public roadways, we are potentially a terrible risk to other drivers. We might have a brain aneurysm, or stroke, or heart attack, or seizure; a tire might blow, or we might get fatally distracted or frightened; we might misread traffic, or overreact to a traffic situation or fellow driver, or misjudge a turn, or lane change, or how long it will take to come to a stop. Any of these things can result in driving fatalities - and often do - and yet billions of people cars drive along roadways every day. Do we say, "You're an evil person for driving a car, knowing the great risks to others you cause when you do so!" No.
Parents have no guarantee they won't give birth to a sociopath, to a child who will grow up to be the next Stalin, or Hitler, or Jeffrey Dahmer. Parents don't know when they have a child, whether or not that child will cause some terrible accident, harming or killing others. Parents cannot be certain that their child won't cause them and others terrible heartache and misery, their child becoming addicted, or obsessed, or suicidal. And yet, when a couple gets pregnant, we don't condemn them saying, "You know there are terrible things that have and can happen as a result of giving birth to a child. You're evil for having a child, knowing this is the case!" No, instead, we celebrate the advent of new life into the world.
How, then, is God's knowing in advance that some will choose Him to their everlasting benefit and some will hate Him to their everlasting hurt make God evil? Again, under the same sort of circumstance, what about people who live in extreme poverty and never even hear about Christianity in their life do they also go to he'll forever we don't come to the same conclusion about the car driver or parent.
what about people who live in extreme poverty and never even hear about Christianity in their life do they also go to he'll forever
People don't go to hell because they haven't heard the Gospel, or because they are poverty-stricken, but because they are
sinners, having disobeyed the "Law of God written on their hearts," and "suppressed the truth (about God) in unrighteousness." No one possessed of a normal-functioning brain in life will stand before God and be able to say, "I had no idea you existed!" No one of this sort will be able to claim
never to have known that the wrong they did was actually wrong. Any person, no matter in what time or place, who follows the innate awareness of God all humans possess, seeking to draw near to God will find Him. God has promised that He will do so and many are the stories of people in all regions of the world whose lives testify to God's eagerness to fulfill His promise. No one who truly wants to know God, who is seeking for Him with their whole heart, will find themselves disappointed.
this feels like a massive plot hole also im not looking to start a argument just a genuine question
Not really. See above.